Polyfill span Encoding APIs #120612
Merged
Polyfill span Encoding APIs #120612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
There was a problem hiding this comment.
Pull Request Overview
This PR removes duplicated encoding fallback code that was forced to pin buffers for older target frameworks by introducing polyfills and utilizing the IncludeSpanPolyfills property. The changes consolidate encoding operations to use modern span-based APIs consistently across all target frameworks.
Key changes:
- Removes custom span-to-pointer bridging code in favor of centralized polyfills
- Replaces custom
Utf8GetStringhelper methods with directEncoding.UTF8.GetStringcalls - Adds
IncludeSpanPolyfills=trueto project files that need encoding polyfills
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| JsonWriterHelper.cs | Simplified UTF-8 encoding methods by removing manual buffer pinning |
| ThrowHelper.cs | Replaced custom UTF-8 string conversion with standard encoding method |
| JsonHelpers.cs | Removed custom Utf8GetString helper method and updated callers |
| EncodingPolyfills.cs | Added centralized polyfills for span-based encoding APIs |
| Directory.Build.targets | Added polyfills to the build system |
| Various .csproj files | Enabled span polyfills for affected libraries |
src/libraries/System.Formats.Asn1/src/System/Formats/Asn1/AsnDecoder.Text.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
stephentoub
reviewed
Oct 10, 2025
stephentoub
reviewed
Oct 10, 2025
src/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Show resolved
Hide resolved
stephentoub
approved these changes
Oct 10, 2025
teo-tsirpanis
added
area-Meta
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/area-meta |
jkotas
reviewed
Oct 11, 2025
This was referenced Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a bunch of duplicated fallbacks that were forced to pin the buffers
#94941